feat: status 기반 소크라테스 clarification gate와 repair loop 안정화#102
Merged
Conversation
- status 기반 open/resolved clarification contract와 intake/status gate를 v3로 전환 - reopen 시 downstream phase까지 pending으로 되돌리도록 runtime과 회귀 테스트를 보강 - docs, skills, workflow task artifact를 새 contract와 cleanup 범위에 맞춰 정리
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff7d096d80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- legacy clarification intake가 status 없이도 load, plan, doctor 경로에서 정규화되게 보정 - pre-v3 task의 locked intake 회귀를 막는 CLI 테스트를 추가 - review feedback에서 지적된 loader 회귀를 phase-1 범위에서 수정
- legacy intake compatibility 수정 이후 phase-1/phase-2 verification evidence를 다시 기록 - task-harness-socratic-uncertainty-gate를 review_ready 상태로 복구 - follow-up repair loop의 kickoff, verification, review run artifact를 남김
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Status: open|resolved기반 clarification gate로 전환했습니다.approve가 실패하고,status는 readiness와 open/resolved 집계를 함께 노출하도록 바꿨습니다.status,plan,doctor경로에서 정상적으로 읽히도록 했습니다.reopen시 target phase뿐 아니라 downstream phase까지pending으로 되돌리도록 repair loop semantics를 보강했고, 과거 task artifact는 정리해 현재 harness task만 남겼습니다.Linked Issue
How
approve/statusruntime을question/answer/decision/status모델로 단순화하고contract_version = 3으로 올렸습니다.contract_version < 3task는 legacyresolvedclarification schema를 loader/consistency 경계에서status기반으로 정규화하도록 보강했습니다.new템플릿, AGENTS, docs, workflow-local skills, CLI 테스트를 새 clarification contract와 reopen semantics에 맞춰 함께 갱신했습니다.reopen로직과 회귀 테스트를 추가했습니다.workflows/tasks/에서는task-harness-socratic-uncertainty-gate만 남기고 나머지 과거 task artifact를 제거했고, review follow-up verification evidence를 다시 남겼습니다.Validation Summary
python3 -m unittest tests.test_workflow_cli -vpython3 scripts/workflow.py doctorpython3 scripts/workflow.py status --all --checktask-harness-socratic-uncertainty-gate를 reopen 후 phase-1/phase-2 verification까지 다시 태워 현재review_ready상태를 확인했습니다.Reviewer Focus
reopen시 downstream phase reset과 follow-up verification evidence가 실제 repair loop semantics와 맞는지Impact / Risks
Status:contract를 기준으로 봐야 합니다.review_ready로 복구됐고, 최종completedcloseout에는 다시 explicit user validation이 필요합니다.